Skip to content

Clean up standalone save/persistence review noise#920

Merged
notfood merged 1 commit into
rwmt:devfrom
MhaWay:multiplayer-pr-cleanup
May 14, 2026
Merged

Clean up standalone save/persistence review noise#920
notfood merged 1 commit into
rwmt:devfrom
MhaWay:multiplayer-pr-cleanup

Conversation

@MhaWay
Copy link
Copy Markdown
Contributor

@MhaWay MhaWay commented May 14, 2026

Summary

This is a cleanup-only follow-up for the standalone save/persistence work already merged in 0dea755.

The goal is to reduce review noise around that code so the remaining logic is easier to read.

Changes

  • removed leftover commented-out reload cache code in SaveLoad and wired the existing cache handoff back in
  • cleaned up a small formatting issue in ConstantTicker
  • clarified the VTR sync comment
  • resolved two simple server-side TODOs by clamping chat length and gating direct debug handling behind dev mode
  • added focused tests for the debug gate behavior

Validation

  • dotnet test Tests --filter StandaloneMapStreamingTest
  • dotnet build Client\Multiplayer.csproj

Copilot AI review requested due to automatic review settings May 14, 2026 19:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up follow-up noise around standalone save/persistence and tightens a couple of server-side behaviors without changing the broader architecture.

Changes:

  • Re-enabled cache handoff during save/reload and removed leftover commented-out code.
  • Added server-side chat length clamping and dev-mode gating for debug packets.
  • Clarified comments/formatting and added focused debug-gate tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Source/Tests/StandaloneMapStreamingTest.cs Adds tests for debug packet behavior with dev mode disabled/enabled.
Source/Common/Networking/State/ServerPlayingState.cs Clamps chat messages and rejects debug handling when dev mode is unavailable.
Source/Client/Saving/SaveLoad.cs Restores cache handoff assignments during save/reload.
Source/Client/Patches/VTRSyncPatch.cs Clarifies the synchronized VTR update-rate comment.
Source/Client/ConstantTicker.cs Adjusts autosave branch formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@notfood notfood added enhancement New feature or request. 1.6 Fixes or bugs relating to 1.6 (Not Odyssey). standalone server Fix or bugs relating to the standalone server. labels May 14, 2026
@notfood notfood merged commit b38a882 into rwmt:dev May 14, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.6 Fixes or bugs relating to 1.6 (Not Odyssey). enhancement New feature or request. standalone server Fix or bugs relating to the standalone server.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants