Make every directory we load look like a .mint directory#159
Merged
kylekthompson merged 1 commit intomainfrom Jun 12, 2025
Merged
Make every directory we load look like a .mint directory#159kylekthompson merged 1 commit intomainfrom
kylekthompson merged 1 commit intomainfrom
Conversation
TAGraves
approved these changes
Jun 12, 2025
robinaugh
added a commit
that referenced
this pull request
Feb 18, 2026
…n sync The skipDirs check in readRwxDirectoryEntries only matched prefixed paths like ".rwx/downloads", but when called via rwxDirectoryEntries (the path used for runs), relativeTo is set to the .rwx dir itself, so entry.Path is just "downloads". Add the unprefixed names so the skip works in both call paths. This bug was introduced in #159 which changed the relativeTo logic but didn't update the skipDirs values to match.
robinaugh
added a commit
that referenced
this pull request
Feb 18, 2026
…n sync The skipDirs check in readRwxDirectoryEntries only matched prefixed paths like ".rwx/downloads", but when called via rwxDirectoryEntries (the path used for runs), relativeTo is set to the .rwx dir itself, so entry.Path is just "downloads". Add the unprefixed names when relativeTo is set so the skip works in both call paths. This bug was introduced in #159 which changed the relativeTo logic but didn't update the skipDirs values to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.6.0 introduced a regression when
--diris provided a directory named something other than.rwxor.mint. Right now, RWX Cloud expects the files to be prefixed with one of those names and the call tofilepath.Basewould have used whatever the name of the directory was.We'll release this temporarily as v1.6.1 and then I'll get a proper change in to no longer consider the directory.