Return exit code 1 when --wait detects a failed run#373
Merged
Conversation
Previously, `rwx run --wait` and `rwx results --wait` would exit 0 even when the run result status was "failed". Now both commands return a non-zero exit code when the completed run did not succeed.
TAGraves
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rwx run --waitandrwx results --waitnow return exit code 1 when the run result status is notsucceededHandledErrorso output is still printed cleanly without a redundant error messageTest plan
require.True(t, result.Completed)assertion to existing failure polling testgo test ./internal/cli/... ./cmd/...)