Skip to content

Conversation

@RichardKelters
Copy link

@RichardKelters RichardKelters commented Aug 2, 2020

Five functions to case selected text. (I'm fairly new with Github so excuse if I did not follow protocol correctly)

@rxi
Copy link
Owner

rxi commented Aug 4, 2020

Looks good! a couple of points:

  • You can add all the commands with a single call of command.add and one table with all the functions in it
  • upper and lower are already provided by core (doc:upper-case, doc:lower-case)
  • The alt+l shortcut conflicts with the default root:switch-to-right command

@RichardKelters
Copy link
Author

Hi rxi,

Thanks for this review. I'm new to lua and did not notice the available functions, will make some changes later.

Richard

@RichardKelters RichardKelters deleted the case branch August 25, 2020 06:48
Jipok pushed a commit to Jipok/lite-plugins that referenced this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants