fix: update xcode info plist#30
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates iOS app metadata for App Store export compliance and adjusts the local permission hook server to accept multiple concurrently-valid hook tokens (to avoid invalidating in-flight agents). It also changes the GitHub OAuth client ID used for device-flow authentication.
Changes:
- Add
ITSAppUsesNonExemptEncryptiontoRxCodeMobile/Info.plist. - Update
PermissionServerto mint and accept multiple valid run tokens (with bounded retention) and remove run-token refresh calls fromAppState. - Update
GitHubServiceOAuth client ID constant.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| RxCodeMobile/Info.plist | Adds App Store encryption compliance flag. |
| RxCode/Services/PermissionServer.swift | Reworks hook token handling to support multiple concurrent CLI launches. |
| RxCode/Services/GitHubService.swift | Updates the GitHub OAuth client ID used for device flow and settings links. |
| RxCode/App/AppState.swift | Removes run-token refresh calls; relies on hook settings file generation to mint tokens. |
Comments suppressed due to low confidence (1)
RxCode/Services/PermissionServer.swift:327
mintRunTokenevicts the oldest token oncemaxValidRunTokensis exceeded. Any still-running CLI subprocess that continues using an evicted token will start getting 403s on subsequent tool calls. Consider tracking token last-seen time (or associating tokens with session IDs) and evicting only tokens that are definitely stale, or making the cap configurable.
let token = UUID().uuidString
validRunTokens.append(token)
if validRunTokens.count > Self.maxValidRunTokens {
validRunTokens.removeFirst(validRunTokens.count - Self.maxValidRunTokens)
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
6
to
10
| actor GitHubService { | ||
|
|
||
| static let oauthClientId = "Ov23liaj3hlJoMGsNZTW" | ||
| static let oauthClientId = "Ov23li0plkoiQCmLm5O5" | ||
| private let clientId = oauthClientId | ||
| private let logger = Logger(subsystem: "com.claudework", category: "GitHubService") |
Comment on lines
+28
to
+32
| /// Hook tokens currently accepted on the `/hook/pre-tool-use` path. Each CLI | ||
| /// subprocess gets its own (see `mintRunToken`), so spawning a new agent never | ||
| /// invalidates the hook URL of an agent already running. Ordered oldest-first; | ||
| /// bounded by `maxValidRunTokens`. | ||
| private var validRunTokens: [String] = [] |
Contributor
Author
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.