fix: item's location detail navigation issue#126
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Fixes an iOS navigation gap where ItemDetailView couldn’t navigate to entity detail screens (notably Location) in some presentation contexts by ensuring entity destinations are registered.
Changes:
- Add
.entityNavigationDestinations()toItemDetailView’s iOS navigation modifier chain. - Update the location navigation UI test to wait longer and attempt to interact with the Location detail bottom sheet.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| RxStorage/RxStorage/Views/Items/ItemDetailView.swift | Registers entity navigation destinations while on ItemDetailView (iOS). |
| RxStorage/RxStorageUITests/RxStorageTagNavigationTests.swift | Modifies the location navigation test flow (timeouts + sheet interactions). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| .navigationDestination(item: $selectedTagIdForNavigation) { tagId in | ||
| TagDetailView(tagId: tagId) | ||
| } | ||
| .entityNavigationDestinations() |
Comment on lines
+100
to
+103
| let element = app/*@START_MENU_TOKEN@*/ .buttons["Sheet Grabber"]/*[[".otherElements.buttons[\"Sheet Grabber\"]",".buttons[\"Sheet Grabber\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/ .firstMatch | ||
| element/*@START_MENU_TOKEN@*/ .swipeUp()/*[[".swipeUp()",".swipeRight()"],[[[-1,1],[-1,0]]],[1]]@END_MENU_TOKEN@*/ | ||
|
|
||
| element.swipeUp() |
Comment on lines
+105
to
+112
| // wait 30 seconds | ||
| app/*@START_MENU_TOKEN@*/ .buttons["item-row"]/*[[".buttons",".containing(.image, identifier: \"chevron.forward\")",".containing(.staticText, identifier: \"This is a public test item for E2E testing\")",".containing(.staticText, identifier: \"item-row\")",".cells.buttons",".otherElements",".buttons[\"Public Test Item, This is a public test item for E2E testing\"]",".buttons[\"item-row\"]"],[[[-1,7],[-1,6],[-1,5,2],[-1,4],[-1,0,1]],[[-1,3],[-1,2],[-1,1]],[[-1,7],[-1,6]]],[0]]@END_MENU_TOKEN@*/ .firstMatch.tap() | ||
|
|
||
| app.staticTexts["Test Category"].firstMatch.tap() | ||
| app.navigationBars.buttons.firstMatch.tap() | ||
|
|
||
| app.staticTexts["Test Author"].firstMatch.tap() | ||
| app.navigationBars.buttons.firstMatch.tap() |
sirily11
force-pushed
the
navigation-fix
branch
from
c56744d to
e94ee12
Compare
Contributor
Author
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.