-
Notifications
You must be signed in to change notification settings - Fork 0
feat: light mode, Payload tab, and bug fixes #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
d6136bf
fix(devtools-ui): theme toggle eager append and resize handle overlap
ryanbas21 922bf5c
address review feedback: rename test, remove hedge, add CSS fallback
pullfrog[bot] a5b2695
test: assert Request Body is absent for GET in payload tab e2e
pullfrog[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import { test, expect } from '../fixtures/extension.js'; | ||
| import { openPanelPage } from '../helpers/panel-page.js'; | ||
|
|
||
| test.describe('import error handling', () => { | ||
| test('submitting invalid JSON shows error banner', async ({ extensionContext, extensionId }) => { | ||
| const panelPage = await extensionContext.newPage(); | ||
| await openPanelPage(panelPage, extensionId); | ||
|
|
||
| // Open import paste area | ||
| const importBtn = panelPage.locator('.tb-btn', { hasText: 'Import' }); | ||
| await importBtn.click(); | ||
|
|
||
| const pasteArea = panelPage.locator('.import-paste-textarea'); | ||
| await expect(pasteArea).toBeVisible(); | ||
|
|
||
| // Paste invalid JSON | ||
| await pasteArea.fill('not valid json {{{'); | ||
| const submitBtn = panelPage.locator('.import-paste .tb-btn', { hasText: 'Import' }); | ||
| await submitBtn.click(); | ||
|
|
||
| // Error banner should appear | ||
| const errBanner = panelPage.locator('.err-banner'); | ||
| await expect(errBanner).toBeVisible({ timeout: 3000 }); | ||
|
|
||
| // Panel should remain functional | ||
| await expect(panelPage.locator('.toolbar')).toBeVisible(); | ||
|
|
||
| await panelPage.close(); | ||
| }); | ||
|
|
||
| test('submitting valid JSON with wrong schema shows error banner', async ({ | ||
| extensionContext, | ||
| extensionId, | ||
| }) => { | ||
| const panelPage = await extensionContext.newPage(); | ||
| await openPanelPage(panelPage, extensionId); | ||
|
|
||
| // Open import paste area | ||
| const importBtn = panelPage.locator('.tb-btn', { hasText: 'Import' }); | ||
| await importBtn.click(); | ||
|
|
||
| const pasteArea = panelPage.locator('.import-paste-textarea'); | ||
| await expect(pasteArea).toBeVisible(); | ||
|
|
||
| // Paste valid JSON but wrong schema (missing required fields) | ||
| await pasteArea.fill(JSON.stringify({ version: 999, flow: {} })); | ||
| const submitBtn = panelPage.locator('.import-paste .tb-btn', { hasText: 'Import' }); | ||
| await submitBtn.click(); | ||
|
|
||
| // Error banner should appear | ||
| const errBanner = panelPage.locator('.err-banner'); | ||
| await expect(errBanner).toBeVisible({ timeout: 3000 }); | ||
|
|
||
| // Panel should remain functional | ||
| await expect(panelPage.locator('.toolbar')).toBeVisible(); | ||
|
|
||
| await panelPage.close(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import { test, expect } from '../fixtures/extension.js'; | ||
| import { openPanelPage } from '../helpers/panel-page.js'; | ||
| import { | ||
| injectDiscovery, | ||
| injectTokenRequest, | ||
| reloadAndWaitForEvents, | ||
| } from '../helpers/inject-events.js'; | ||
|
|
||
| test.describe('payload tab', () => { | ||
| test('Payload tab appears for network events with request/response body', async ({ | ||
| extensionContext, | ||
| extensionId, | ||
| mockServer, | ||
| }) => { | ||
| const panelPage = await extensionContext.newPage(); | ||
| await openPanelPage(panelPage, extensionId); | ||
|
|
||
| // Inject discovery + token request (token has postData and JSON response body) | ||
| await injectDiscovery(panelPage, mockServer.baseUrl); | ||
| await injectTokenRequest(panelPage, mockServer.baseUrl); | ||
| await reloadAndWaitForEvents(panelPage, 2); | ||
|
|
||
| // Select the token event (second row, after discovery) | ||
| await panelPage.locator('.tl-row').nth(1).click(); | ||
|
|
||
| // Payload tab should be visible (event has requestBody + responseBody) | ||
| const payloadTab = panelPage.locator('.tab-btn', { hasText: 'Payload' }); | ||
| await expect(payloadTab).toBeVisible({ timeout: 3000 }); | ||
|
|
||
| // Click the Payload tab | ||
| await payloadTab.click(); | ||
| await expect(payloadTab).toHaveClass(/active/); | ||
|
|
||
| // Should show payload sections | ||
| await expect(panelPage.locator('.payload-section').first()).toBeVisible(); | ||
| await expect(panelPage.locator('.sect-hdr', { hasText: 'Request Body' })).toBeVisible(); | ||
| await expect(panelPage.locator('.sect-hdr', { hasText: 'Response Body' })).toBeVisible(); | ||
|
|
||
| await panelPage.close(); | ||
| }); | ||
|
|
||
| test('Payload tab for discovery events shows only Response Body section', async ({ | ||
| extensionContext, | ||
| extensionId, | ||
| mockServer, | ||
| }) => { | ||
| const panelPage = await extensionContext.newPage(); | ||
| await openPanelPage(panelPage, extensionId); | ||
|
|
||
| // Discovery is a GET request with no postData — only has responseBody | ||
| await injectDiscovery(panelPage, mockServer.baseUrl); | ||
| await injectTokenRequest(panelPage, mockServer.baseUrl); | ||
| await reloadAndWaitForEvents(panelPage, 2); | ||
|
|
||
| // Select the discovery event (first row) — it's a GET with no postData | ||
| await panelPage.locator('.tl-row').first().click(); | ||
|
|
||
| // Discovery has responseBody (the OIDC config JSON), so Payload tab | ||
| // should appear. But it has no requestBody, so only Response Body shows. | ||
| const payloadTab = panelPage.locator('.tab-btn', { hasText: 'Payload' }); | ||
| await expect(payloadTab).toBeVisible({ timeout: 3000 }); | ||
| await payloadTab.click(); | ||
| await expect(payloadTab).toHaveClass(/active/); | ||
| await expect(panelPage.locator('.sect-hdr', { hasText: 'Response Body' })).toBeVisible(); | ||
| await expect(panelPage.locator('.sect-hdr', { hasText: 'Request Body' })).not.toBeVisible(); | ||
|
|
||
| await panelPage.close(); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| import { test, expect } from '../fixtures/extension.js'; | ||
| import { openPanelPage } from '../helpers/panel-page.js'; | ||
|
|
||
| test.describe('theme toggle', () => { | ||
| test('theme toggle button is visible in toolbar', async ({ extensionContext, extensionId }) => { | ||
| const panelPage = await extensionContext.newPage(); | ||
| await openPanelPage(panelPage, extensionId); | ||
|
|
||
| // The theme toggle is appended by JS after Elm renders the toolbar | ||
| const toggleBtn = panelPage.locator('.theme-toggle'); | ||
| await expect(toggleBtn).toBeVisible({ timeout: 3000 }); | ||
|
|
||
| await panelPage.close(); | ||
| }); | ||
|
|
||
| test('clicking toggle switches to light mode and back', async ({ | ||
| extensionContext, | ||
| extensionId, | ||
| }) => { | ||
| const panelPage = await extensionContext.newPage(); | ||
| await openPanelPage(panelPage, extensionId); | ||
|
|
||
| const toggleBtn = panelPage.locator('.theme-toggle'); | ||
| await expect(toggleBtn).toBeVisible({ timeout: 3000 }); | ||
|
|
||
| // Get initial theme state | ||
| const initialTheme = await panelPage.evaluate(() => | ||
| document.documentElement.getAttribute('data-theme'), | ||
| ); | ||
|
|
||
| // Click to switch theme | ||
| await toggleBtn.click(); | ||
| const afterFirstClick = await panelPage.evaluate(() => | ||
| document.documentElement.getAttribute('data-theme'), | ||
| ); | ||
|
|
||
| if (initialTheme === null) { | ||
| expect(afterFirstClick).toBe('light'); | ||
| } else { | ||
| expect(afterFirstClick).toBeNull(); | ||
| } | ||
|
|
||
| // Click again to toggle back | ||
| await toggleBtn.click(); | ||
| const afterSecondClick = await panelPage.evaluate(() => | ||
| document.documentElement.getAttribute('data-theme'), | ||
| ); | ||
| expect(afterSecondClick).toBe(initialTheme); | ||
|
|
||
| await panelPage.close(); | ||
| }); | ||
|
|
||
| test('theme preference persists across page reloads', async ({ | ||
| extensionContext, | ||
| extensionId, | ||
| }) => { | ||
| const panelPage = await extensionContext.newPage(); | ||
| await openPanelPage(panelPage, extensionId); | ||
|
|
||
| const toggleBtn = panelPage.locator('.theme-toggle'); | ||
| await expect(toggleBtn).toBeVisible({ timeout: 3000 }); | ||
|
|
||
| // Get initial state | ||
| const initialTheme = await panelPage.evaluate(() => | ||
| document.documentElement.getAttribute('data-theme'), | ||
| ); | ||
|
|
||
| // Toggle the theme | ||
| await toggleBtn.click(); | ||
| const newTheme = await panelPage.evaluate(() => | ||
| document.documentElement.getAttribute('data-theme'), | ||
| ); | ||
| expect(newTheme).not.toBe(initialTheme); | ||
|
|
||
| // Verify localStorage was updated | ||
| const storedTheme = await panelPage.evaluate(() => localStorage.getItem('wolfcola:theme')); | ||
| expect(storedTheme).toBe(newTheme === 'light' ? 'light' : 'dark'); | ||
|
|
||
| // Reload and verify theme persists | ||
| await panelPage.reload(); | ||
| await panelPage.waitForSelector('.toolbar', { state: 'visible' }); | ||
|
|
||
| const themeAfterReload = await panelPage.evaluate(() => | ||
| document.documentElement.getAttribute('data-theme'), | ||
| ); | ||
| expect(themeAfterReload).toBe(newTheme); | ||
|
|
||
| await panelPage.close(); | ||
| }); | ||
|
|
||
| test('toggle button survives Elm re-render', async ({ extensionContext, extensionId }) => { | ||
| const panelPage = await extensionContext.newPage(); | ||
| await openPanelPage(panelPage, extensionId); | ||
|
|
||
| await expect(panelPage.locator('.theme-toggle')).toBeVisible({ timeout: 3000 }); | ||
|
|
||
| // Trigger an Elm re-render by injecting an SDK event | ||
| await panelPage.evaluate(() => { | ||
| chrome.runtime.sendMessage({ | ||
| type: 'SDK_EVENT', | ||
| payload: { | ||
| type: 'sdk:node-change', | ||
| id: `theme-test-${Date.now()}`, | ||
| flowId: 'theme-flow', | ||
| timestamp: Date.now(), | ||
| source: 'sdk', | ||
| causedBy: null, | ||
| data: { _tag: 'sdk', nodeStatus: 'continue' }, | ||
| flags: { isCors: false, isError: false, isAuthRelated: true }, | ||
| }, | ||
| }); | ||
| }); | ||
|
|
||
| // Wait for the event to appear (forces Elm re-render) | ||
| await panelPage.waitForSelector('.tl-row', { state: 'visible', timeout: 5000 }); | ||
|
|
||
| // Toggle should still be there after Elm re-rendered | ||
| await expect(panelPage.locator('.theme-toggle')).toBeVisible({ timeout: 3000 }); | ||
|
|
||
| await panelPage.close(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.