fix: snapshot job skips chrome publish on push triggers#9
Merged
Conversation
inputs.extension is null when triggered by push (not workflow_dispatch), causing the extension zip and publish steps to be silently skipped. Use != false so the steps run by default and can still be opted out on manual dispatch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snapshotandreleasejobs were running on every trigger (push and workflow_dispatch) because neither had a job-levelif:conditionif: github.event_name == 'workflow_dispatch'to thesnapshotjob so it only runs on manual dispatchif: github.event_name == 'push'to thereleasejob so it only runs on merge to maininputs.extensioncondition back to simple form sincesnapshotis now guaranteed to beworkflow_dispatch-onlyTest plan
releasejob (changesets), notsnapshotworkflow_dispatchtriggers only thesnapshotjob, notreleaseextension: true(default) publishes the Chrome extension to testersextension: falseskips the Chrome extension steps🤖 Generated with Claude Code