feat: xHCI endpoint matching, EP0 GET_REPORT, MSI hardening#238
Merged
feat: xHCI endpoint matching, EP0 GET_REPORT, MSI hardening#238
Conversation
…SI hardening Major xHCI driver overhaul to match Linux's exact initialization sequence on Parallels ARM64 virtual xHC (NEC uPD720200). Key changes: - Batch ConfigureEndpoint with all endpoints in single command (matches Linux) - Drop+Add toggle reset per endpoint after initial ConfigureEndpoint - Full 32-byte Slot Context copy matching Linux xhci_slot_copy - Mult=0 for non-isochronous endpoints per xHCI spec §6.2.3 - EP0 GET_REPORT polling for keyboard input (working at 4Hz) - Deferred TRB queueing after SPI enable to avoid race conditions - GIC DSB+ISB barriers on SPI enable/disable to prevent MSI storms - Comprehensive heartbeat diagnostics for xHCI state monitoring - USB descriptor additions: BOS, SET_INTERFACE, SET_ISOCH_DELAY, SET_REPORT - MAX_SLOTS increased to 32 to match Linux CONFIG value - .gitignore: exclude esp/ build artifact and debug capture files Interrupt endpoint transfers still return CC=12 (Endpoint Not Enabled), investigation ongoing. EP0 control transfers work correctly. Co-Authored-By: Ryan Breen <rbreen@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xhci_check_bandwidth+xhci_endpoint_resetflowChanges
kernel/src/drivers/usb/xhci.rs: Major rewrite — batch endpoint config, Drop+Add reset, EP0 polling, deferred TRB queueing, endpoint state diagnosticskernel/src/arch_impl/aarch64/gic.rs: DSB+ISB barriers on SPI enable/disablekernel/src/arch_impl/aarch64/timer_interrupt.rs: Extended heartbeat with xHCI transfer/error/doorbell/endpoint diagnosticskernel/src/drivers/usb/descriptors.rs: BOS descriptor type, SET_INTERFACE, SET_ISOCH_DELAY, SET_REPORT requestskernel/src/drivers/mod.rs: Raw serial debug breadcrumbs for xHCI init path.gitignore: Excludeesp/build artifact and debug capture filesStatus
Interrupt endpoint transfers still return CC=12 (Endpoint Not Enabled) on the Parallels virtual xHC despite endpoint contexts matching Linux byte-for-byte. EP0 control transfers work correctly. Investigation ongoing.
Test plan
🤖 Generated with Claude Code