Fix ARM64 fork kernel stack reuse for bsshd#406
Merged
Conversation
Replace the ARM64 kernel stack bump allocator with bitmap-backed reuse and move fork-child stack ownership into the scheduler thread clone so waitpid cannot free a stack while CPU scheduler state may still reference it. Verified with 150 strict-host-key inbound bsshd handshakes on a fresh ARM64 Parallels boot, passing beyond the prior ENOMEM failure at handshake 91. Co-authored-by: Ryan Breen <ryan@ryanbreen.com> Co-authored-by: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
TURN 337 reproduced the inbound bsshd degradation on a fresh ARM64/Parallels boot at strict-host-key handshake 91, after 90 successful SSH exec sessions. Serial showed bsshd accepted the connection and reached fork, then failed with Os(ENOMEM). That points to ARM64 fork/kernel-stack allocation, not TCP receive or userspace SSH packet handling.
Verification
Artifacts: /Users/wrb/Downloads/Ralph/breenix-interrupt-io-roadmap-1780056222/turn337-artifacts/
Note: full cargo fmt is still blocked by pre-existing unrelated trailing whitespace in tests/shared_qemu.rs; the touched files were checked with rustfmt directly.