Skip to content

Conversation

@ryanfowler
Copy link
Owner

Implement the Shell interface for bash, adding tab completion via COMP_WORDS/COMPREPLY with -o nosort -o nospace flags. Update docs, install script, and CLI flag values to include bash alongside fish and zsh.

Implement the Shell interface for bash, adding tab completion via
COMP_WORDS/COMPREPLY with -o nosort -o nospace flags. Update docs,
install script, and CLI flag values to include bash alongside fish
and zsh.
@ryanfowler ryanfowler requested a review from Copilot February 3, 2026 18:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds bash shell completion support to the fetch CLI tool, implementing the Shell interface for bash alongside the existing fish and zsh implementations.

Changes:

  • Implements Bash struct with Register() and Complete() methods using COMP_WORDS/COMPREPLY
  • Adds "bash" as a valid value for the --complete flag
  • Updates documentation and install script with bash completion instructions

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/complete/shells.go Adds Bash struct implementing Shell interface with completion logic
internal/complete/complete_test.go Adds comprehensive test cases for bash completion scenarios
internal/cli/cli_test.go Adds test to verify flags are in alphabetical order
internal/cli/app.go Reorders flags alphabetically and adds "bash" to --complete flag values
install.sh Adds bash completion installation to .bashrc
docs/getting-started.md Documents bash completion setup command
docs/cli-reference.md Updates --complete flag documentation to include bash

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ryanfowler ryanfowler merged commit ca121c8 into main Feb 3, 2026
10 checks passed
@ryanfowler ryanfowler deleted the bash-completion branch February 3, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant