Skip to content

Fix AWS SigV4 header whitespace canonicalization#473

Merged
ryanfowler merged 1 commit intomainfrom
fix-aws-sigv4-whitespace
Apr 16, 2026
Merged

Fix AWS SigV4 header whitespace canonicalization#473
ryanfowler merged 1 commit intomainfrom
fix-aws-sigv4-whitespace

Conversation

@ryanfowler
Copy link
Copy Markdown
Owner

Summary

  • Canonicalize each AWS SigV4 header value before signing
  • Collapse internal whitespace runs to a single space and join multi-value headers with commas
  • Avoid extra allocations for already-canonical single header values
  • Add regression coverage for multi-value and internal-whitespace header cases

Testing

  • go test -v ./internal/aws
  • go test -v ./...

@ryanfowler ryanfowler enabled auto-merge April 16, 2026 15:52
@ryanfowler ryanfowler merged commit 6b4856b into main Apr 16, 2026
10 checks passed
@ryanfowler ryanfowler deleted the fix-aws-sigv4-whitespace branch April 16, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant