Skip to content

Fix SigV4 canonical path handling for escaped URLs#528

Merged
ryanfowler merged 1 commit into
mainfrom
fix-sigv4-canonical-path
May 15, 2026
Merged

Fix SigV4 canonical path handling for escaped URLs#528
ryanfowler merged 1 commit into
mainfrom
fix-sigv4-canonical-path

Conversation

@ryanfowler
Copy link
Copy Markdown
Owner

Summary

  • Build the AWS SigV4 canonical URI from URL.EscapedPath() instead of the decoded URL.Path
  • Preserve escaped octets like %2F and normalize percent-encoding case for canonical signing
  • Remove the obsolete decoded-path escaping helper and add coverage for escaped slash, escaped space, and non-ASCII segments

Testing

  • go test -v ./internal/aws
  • staticcheck ./...
  • go test -v ./...

@ryanfowler ryanfowler enabled auto-merge May 15, 2026 00:39
@ryanfowler ryanfowler merged commit 1d31f84 into main May 15, 2026
10 checks passed
@ryanfowler ryanfowler deleted the fix-sigv4-canonical-path branch May 15, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant