Fix environment proxy handling for HTTP/2 and HTTP/3#586
Merged
Conversation
ryanfowler
force-pushed
the
fix-env-proxy-http2-guard
branch
from
437f1ae to
46ce5e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--proxy.a proxy can only be used with HTTP/1.1error.HTTPS_PROXYwith--http 2and--http 3, plus a small unit test for the envNO_PROXYmatch path.Testing
cargo fmtcargo clippy --locked --all-targets --all-features -- -D warningscargo test --all-featurescargo test --all-features --test integration -- --test-threads=1