Skip to content

Rename timing connect phase label to Connect#602

Merged
ryanfowler merged 1 commit into
mainfrom
rename-timing-connect-phase
May 26, 2026
Merged

Rename timing connect phase label to Connect#602
ryanfowler merged 1 commit into
mainfrom
rename-timing-connect-phase

Conversation

@ryanfowler
Copy link
Copy Markdown
Owner

Summary

  • Render the timing connect phase as Connect instead of TCP in the waterfall and verbose debug output.
  • Update the README wording and timing-related tests to match the new label.
  • Adjust the timing unit test alignment expectation because the longer label shifts the bar start.

Testing

  • cargo fmt
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --all-features timing
  • cargo test --all-features --test integration socks_proxy_unix_socket_timing_and_grpc_binary_cases -- --test-threads=1

@ryanfowler ryanfowler enabled auto-merge May 26, 2026 17:54
@ryanfowler ryanfowler merged commit 39dccd2 into main May 26, 2026
4 checks passed
@ryanfowler ryanfowler deleted the rename-timing-connect-phase branch May 26, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant