Respect the VIPS_CONCURRENCY env var if provided #2747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR modifies the image processing concurrency behavior to respect the VIPS_CONCURRENCY environment variable when set, while maintaining the default concurrency of 1 when the variable is not provided.
Changes:
- Modified sharp concurrency configuration to be conditional based on
VIPS_CONCURRENCYenvironment variable - Relocated and expanded Performance section in README with additional environment variable documentation
- Added documentation for libvips-specific environment variables
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/image.ts | Added conditional check to only set sharp concurrency to 1 when VIPS_CONCURRENCY is not defined |
| README.md | Moved Performance section to end of document and added documentation for VIPS_CONCURRENCY and other environment variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ryanfowler
force-pushed
the
vips-concurrency
branch
from
9a75939 to
70659b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.