Immersive Portals crash / incompatability

[ninyauwu]

Context

Entity collision @ Redirect mixin causes crash on game load. Probably other rendering-related mixins are an issue as well. It would be extremely cool if these two were compatible, though.
Tested with:

• Sable 1.0.6
• Immersive portals 6.0.7

Crash Report

https://mclo.gs/XXk2EiP

[Dausora]

I noticed the same incompatibility after testing with iPortals 6.0.7 and Sable 1.1.3. If anyone finds a workaround (or if a fix is released) I'd love to be notified if possible.

[pacrowde87]

immersive portals is crashing game on launch, conflicting with sable, would be awesome to get this working again

[Jakobabs]

[11:58:58] [main/WARN] [mixin/]: @reDIrect conflict. Skipping imm_ptl.mixins.json:common.collision.MixinEntity from mod immersive_portals_core->@reDIrect::redirectHandleCollisions(Lnet/minecraft/world/entity/Entity;Lnet/minecraft/world/phys/Vec3;)Lnet/minecraft/world/phys/Vec3; with priority 1000, already redirected by sable.mixins.json:entity.entity_sublevel_collision.EntityMixin from mod sable->@reDIrect::sable$collideRedirect(Lnet/minecraft/world/entity/Entity;Lnet/minecraft/world/phys/Vec3;)Lnet/minecraft/world/phys/Vec3; with priority 1100

Both mods are redirecting the Entity Collision Mixin which is causing the crash.

In sable source code: sable/common/src/main/java/dev/ryanhcode/sable/mixin/entity/entity_sublevel_collision/EntityMixin.java at line 110

conflicts with

In Immersive Portals source code: ImmersivePortalsModForNeo/src/main/java/quoteall/imm_ptl/core/mixin/common/collision/MixinEntity.java at line 90

Issue is posted on Immersive Portals aswell.
Hope this helps!

[Alex-Guha]

[11:58:58] [main/WARN] [mixin/]: @reDIrect conflict. Skipping imm_ptl.mixins.json:common.collision.MixinEntity from mod immersive_portals_core->@reDIrect::redirectHandleCollisions(Lnet/minecraft/world/entity/Entity;Lnet/minecraft/world/phys/Vec3;)Lnet/minecraft/world/phys/Vec3; with priority 1000, already redirected by sable.mixins.json:entity.entity_sublevel_collision.EntityMixin from mod sable->@reDIrect::sable$collideRedirect(Lnet/minecraft/world/entity/Entity;Lnet/minecraft/world/phys/Vec3;)Lnet/minecraft/world/phys/Vec3; with priority 1100

Both mods are redirecting the Entity Collision Mixin which is causing the crash.

In sable source code: sable/common/src/main/java/dev/ryanhcode/sable/mixin/entity/entity_sublevel_collision/EntityMixin.java at line 110

conflicts with

In Immersive Portals source code: ImmersivePortalsModForNeo/src/main/java/quoteall/imm_ptl/core/mixin/common/collision/MixinEntity.java at line 90

Issue is posted on Immersive Portals aswell. Hope this helps!

Unfortunately the issues are more extensive then just that, at least for resolving the immediate mod incompatibility - fix this one and a new, more involved issue arises.

That said, the fix for this crash is simple:

@Redirect(method = "move(Lnet/minecraft/world/entity/MoverType;Lnet/minecraft/world/phys/Vec3;)V", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/entity/Entity;collide(Lnet/minecraft/world/phys/Vec3;)Lnet/minecraft/world/phys/Vec3;"))
    public Vec3 sable$collideRedirect(final Entity entity, final Vec3 collisionMotion) {

becomes:

@WrapOperation(method = "move(Lnet/minecraft/world/entity/MoverType;Lnet/minecraft/world/phys/Vec3;)V", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/entity/Entity;collide(Lnet/minecraft/world/phys/Vec3;)Lnet/minecraft/world/phys/Vec3;"))
    public Vec3 sable$collideRedirect(final Entity entity, final Vec3 collisionMotion, final Operation<Vec3> original) {

on line 109-110, and then replace this.collide(beforeVanillaCollision); with original.call(entity, beforeVanillaCollision); on line 158.