Skip to content

more aggressive rust refactoring#161

Open
Random-Scientist wants to merge 1 commit intoryanhcode:mainfrom
Random-Scientist:even_more_refactoring
Open

more aggressive rust refactoring#161
Random-Scientist wants to merge 1 commit intoryanhcode:mainfrom
Random-Scientist:even_more_refactoring

Conversation

@Random-Scientist
Copy link
Copy Markdown
Contributor

@Random-Scientist Random-Scientist commented Apr 19, 2026

this codebase will drive me insane but i'm too stubborn to go to sleep
the great de-nalgebrification.

  • Use glam{x} {D, I}Vec3 as the canonical vector types
  • as a consequence of the above, collapse a huge amount of manual implementations of vector arithmetic to vector methods/overloads
  • pass vectors internally as vectors instead of constantly un and repacking them (rust won't punish you for wrapping your arguments in nice types*)

*usually

@Random-Scientist
Copy link
Copy Markdown
Contributor Author

Random-Scientist commented Apr 19, 2026

before marking this as ready for review i'll go over the diff myself and make sure i got all the operator precedences right 💀

@Random-Scientist
Copy link
Copy Markdown
Contributor Author

Random-Scientist commented Apr 19, 2026

yep... got hit by an operator precedence bug in get_overlapping_nodes. I think that's the only one (at least, everything seems to work now when i mess around ingame, and i went over the changes pretty carefully in my second pass).

@Random-Scientist Random-Scientist marked this pull request as ready for review April 19, 2026 12:45
@tazercopter
Copy link
Copy Markdown
Contributor

sounds like I need to look at this for #125

@ryanhcode
Copy link
Copy Markdown
Owner

ryanhcode commented Apr 19, 2026

we've added a CLA now btw, the workflow should update on the next commit

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 19, 2026

CLA assistant check
All committers have signed the CLA.

@Random-Scientist Random-Scientist force-pushed the even_more_refactoring branch 5 times, most recently from 2f30c1c to 0ac26bb Compare April 21, 2026 00:57
@CherrieTheShifter
Copy link
Copy Markdown

Yes This

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants