declarative natives build script, MSVC for Windows targets + FreeBSD x86 & Windows ARM natives#231
declarative natives build script, MSVC for Windows targets + FreeBSD x86 & Windows ARM natives#231Random-Scientist wants to merge 5 commits intoryanhcode:mainfrom
Conversation
a199529 to
3db1c72
Compare
3db1c72 to
5984c96
Compare
cargo-xwin and Windows ARM nativescargo-xwin and Windows ARM natives
5984c96 to
c287547
Compare
|
It’s working on arm64, it’s very laggy which is odd since it shouldn’t be. |
|
@Random-Scientist I’m seeing what looks like a memory leak with Sable on my setup. Without Sable, the modpack sits around 6–8 GB RAM and is stable, but with Sable enabled, memory continuously climbs from that baseline up to ~25 GB while I’m standing still in a loaded world. FPS drops too, and eventually the whole system runs out of memory and crashes. This doesn’t look like normal modded Minecraft memory usage, since the usage keeps increasing over time instead of leveling off. I’m on Minecraft 1.21.1 / NeoForge / Java 21 on Windows ARM64. |
|
@ActuallyFreshIce are you on the Discord? I don't have a machine to test on and debugging this over github comments would be a giant pain (my username is |
|
That said, i may disable the windows arm natives for this pr just to get it merged, since it brings nice improvements to the primary x86 windows build as well. |
455d64c to
18d4308
Compare
|
Yes This |
cargo-xwin and Windows ARM natives|
In the hopes of getting the rest of the changes merged, i've disabled builds of the Windows ARM natives for now, pending debugging of the memory leak issues mentioned above in a later PR. |
95a24f8 to
c6e127a
Compare
|
Yes I have discord I will add you, username is danfantp |
|
After testing with @ActuallyFreshIce the real culprit for the leak appears to be an interaction with sodium, not an inherent issue with the natives, I'll reenable them, and this should be ready to merge. |
c6e127a to
cfddcbb
Compare
cfddcbb to
5213d6b
Compare
23cea4b to
9442803
Compare
f68d5d0 to
be6b99e
Compare
be6b99e to
cbe00d5
Compare
|
merge please |
the MSVC targets are a much better option than gnullvm for windows ARM (tier 3 toolchain vs tier 1).
not sure if there's a nice approach to sticking everything we need in one container but with caching the duplication isnt too bad.
also not sure if the dev commands should be changed to call local cargo directly, since anyone working on the natives will probably be doing that anyway.
x86_64-apple-darwinrelease builds getcodegen-units = 1, after moving to a workspace, since workspaces ignore profile overrides in member crates' Cargo.toml.