Skip to content

declarative natives build script, MSVC for Windows targets + FreeBSD x86 & Windows ARM natives#231

Open
Random-Scientist wants to merge 5 commits intoryanhcode:mainfrom
Random-Scientist:natives_msvc
Open

declarative natives build script, MSVC for Windows targets + FreeBSD x86 & Windows ARM natives#231
Random-Scientist wants to merge 5 commits intoryanhcode:mainfrom
Random-Scientist:natives_msvc

Conversation

@Random-Scientist
Copy link
Copy Markdown
Contributor

@Random-Scientist Random-Scientist commented Apr 20, 2026

the MSVC targets are a much better option than gnullvm for windows ARM (tier 3 toolchain vs tier 1).

not sure if there's a nice approach to sticking everything we need in one container but with caching the duplication isnt too bad.
also not sure if the dev commands should be changed to call local cargo directly, since anyone working on the natives will probably be doing that anyway.

@Random-Scientist Random-Scientist force-pushed the natives_msvc branch 4 times, most recently from a199529 to 3db1c72 Compare April 20, 2026 03:08
@Random-Scientist Random-Scientist marked this pull request as ready for review April 20, 2026 03:09
@Random-Scientist Random-Scientist changed the title Natives buildscript cleanup, MSVC targets via cargo-xwin and Windows ARM natives natives buildscript cleanup, MSVC targets via cargo-xwin and Windows ARM natives Apr 20, 2026
@ActuallyFreshIce
Copy link
Copy Markdown

ActuallyFreshIce commented Apr 20, 2026

It’s working on arm64, it’s very laggy which is odd since it shouldn’t be.

@ActuallyFreshIce
Copy link
Copy Markdown

@Random-Scientist I’m seeing what looks like a memory leak with Sable on my setup. Without Sable, the modpack sits around 6–8 GB RAM and is stable, but with Sable enabled, memory continuously climbs from that baseline up to ~25 GB while I’m standing still in a loaded world. FPS drops too, and eventually the whole system runs out of memory and crashes.

This doesn’t look like normal modded Minecraft memory usage, since the usage keeps increasing over time instead of leveling off. I’m on Minecraft 1.21.1 / NeoForge / Java 21 on Windows ARM64.

@Random-Scientist
Copy link
Copy Markdown
Contributor Author

Random-Scientist commented Apr 21, 2026

@ActuallyFreshIce are you on the Discord? I don't have a machine to test on and debugging this over github comments would be a giant pain (my username is rsci. over there if you just want to dm me

@Random-Scientist
Copy link
Copy Markdown
Contributor Author

That said, i may disable the windows arm natives for this pr just to get it merged, since it brings nice improvements to the primary x86 windows build as well.

@Random-Scientist Random-Scientist force-pushed the natives_msvc branch 2 times, most recently from 455d64c to 18d4308 Compare April 21, 2026 01:13
@CherrieTheShifter
Copy link
Copy Markdown

Yes This

@Random-Scientist Random-Scientist changed the title natives buildscript cleanup, MSVC targets via cargo-xwin and Windows ARM natives more declarative natives build script, MSVC for Windows targets + FreeBSD x86 and Windows ARM natives Apr 21, 2026
@Random-Scientist Random-Scientist changed the title more declarative natives build script, MSVC for Windows targets + FreeBSD x86 and Windows ARM natives declarative natives build script, MSVC for Windows targets + FreeBSD x86 and Windows ARM natives Apr 21, 2026
@Random-Scientist Random-Scientist changed the title declarative natives build script, MSVC for Windows targets + FreeBSD x86 and Windows ARM natives declarative natives build script, MSVC for Windows targets + FreeBSD x86 natives Apr 21, 2026
@Random-Scientist Random-Scientist changed the title declarative natives build script, MSVC for Windows targets + FreeBSD x86 natives declarative natives build script, MSVC for Windows targets + FreeBSD x86 natives, groundwork for arm windows Apr 21, 2026
@Random-Scientist
Copy link
Copy Markdown
Contributor Author

In the hopes of getting the rest of the changes merged, i've disabled builds of the Windows ARM natives for now, pending debugging of the memory leak issues mentioned above in a later PR.

@ActuallyFreshIce
Copy link
Copy Markdown

Yes I have discord I will add you, username is danfantp

@Random-Scientist
Copy link
Copy Markdown
Contributor Author

Random-Scientist commented Apr 21, 2026

After testing with @ActuallyFreshIce the real culprit for the leak appears to be an interaction with sodium, not an inherent issue with the natives, I'll reenable them, and this should be ready to merge.

@Random-Scientist Random-Scientist changed the title declarative natives build script, MSVC for Windows targets + FreeBSD x86 natives, groundwork for arm windows declarative natives build script, MSVC for Windows targets + FreeBSD x86 & Windows ARM natives Apr 21, 2026
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 21, 2026

CLA assistant check
All committers have signed the CLA.

@pizzapi2012
Copy link
Copy Markdown

pizzapi2012 commented Apr 22, 2026

merge please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

6 participants