fix(release): use positional shell arg for cask completions#97
Merged
Conversation
v0.4.0's cask set shell_parameter_format: arg, which makes Homebrew invoke `things completions --shell=bash`. `things completions` takes the shell as a positional argument, so it rejected the unknown --shell flag (exit 80) and `brew install` wrote no completion files. Drop shell_parameter_format so Homebrew uses its default — a bare positional arg, `things completions bash` — which matches the CLI. Verified against the installed v0.4.0 binary: `completions --shell=bash` exits 80, `completions bash` exits 0. Includes the v0.4.1 release notes header. Part of #88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the completion install broken in v0.4.0. Cuts v0.4.1.
Bug
v0.4.0's cask used
shell_parameter_format: arg, so Homebrew invokedthings completions --shell=bash. Butthings completionstakes the shell as a positional arg, so Kong rejected the unknown--shellflag (exit 80) andbrew installwrote no completion files — with three "Failed to generate … completions" warnings.(The preflight quarantine fix from #95 worked — the binary executed; exit 80 is our own arg-parse error, not a Gatekeeper block.)
Fix
Drop
shell_parameter_formatso Homebrew uses its default: a bare positional arg,things completions bash. The GoReleaser docs claimargmeans positional, but Homebrew's:argactually emits--shell=<name>; bare positional is the no-format default.Generated cask now reads:
Verification
goreleaser check✅; snapshot cask omitsshell_parameter_format✅things completions --shell=bash→ exit 80 (reproduces the failure);things completions bash→ exit 0 emittingcomplete -C things things; all of bash/zsh/fish exit 0 positionally ✅After v0.4.1 releases:
brew update && brew reinstall ryanlewis/tap/thingsshould write the completion files with no warnings.