Fix capabilities for equipping and unequipping tools#31
Merged
Conversation
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Purse’s default sandboxing configuration and documented capabilities to restore backwards compatibility while enabling tool equip/unequip behavior when sandboxing is opted into.
Changes:
- Disable
Sandboxedby default for the Purse model, while updating the capabilities bitmask. - Update documentation to include the additional capabilities needed for equipping/unequipping tools.
- Update MkDocs navigation to link to the sandboxing documentation page.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| models/Purse/init.meta.json | Changes default sandboxing to off and updates the SecurityCapabilities bitmask. |
| mkdocs.yml | Updates docs nav entry from “Capabilities” to “Sandboxing”. |
| docs/sandboxing.md | Rewords sandboxing guidance and adds Avatar-related capabilities to the documented list. |
Comments suppressed due to low confidence (1)
docs/sandboxing.md:7
- The opening paragraph and warning are misleading about how Roblox sandboxed containers/capabilities apply to tools. Purse is a ModuleScript typically placed in ReplicatedStorage, so enabling
Sandboxedon Purse won’t automatically sandbox tools in Backpack/Character (only scripts/instances that are descendants of the sandboxed container are affected), and capabilities are set on scripts/containers—not onToolinstances themselves. Please reword to clarify when tools/scripts are actually sandboxed and where capabilities must be configured. (Also: “Script capabilities are used…”, not “is used”.)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables sandboxing by default and adds missing capabilities.
Instead of using sandboxing always to sandbox everything, including tools, it should be disabled for backwards compatibility.