Skip to content

Generic _media_update() func., added func. to update status with a photo...#56

Merged
ryanmcgrath merged 1 commit intoryanmcgrath:masterfrom
michaelhelmick:status_with_media
Jan 14, 2012
Merged

Generic _media_update() func., added func. to update status with a photo...#56
ryanmcgrath merged 1 commit intoryanmcgrath:masterfrom
michaelhelmick:status_with_media

Conversation

@michaelhelmick
Copy link
Copy Markdown
Collaborator

  • Generic _media_update() func. for the 3 media api calls
  • Added func. to update status with a photo. updateStatusWithMedia()

…oto.

* Generic _media_update() func. for the 3 media api calls

* Added func. to update status with a photo. updateStatusWithMedia()
@ryanmcgrath
Copy link
Copy Markdown
Owner

Yet again, epic work. I'm flying to Switzerland momentarily, but can push out a point release of Twython to pypi when I touch down. Thanks again!

ryanmcgrath pushed a commit that referenced this pull request Jan 14, 2012
Generic _media_update() func., added func. to update status with a photo...
@ryanmcgrath ryanmcgrath merged commit ae5e631 into ryanmcgrath:master Jan 14, 2012
@michaelhelmick
Copy link
Copy Markdown
Collaborator Author

You're welcome. You did see my tweet about 1.4.5 breaking how responses are returned. Right? I think it has something to do with changing get() to _constructFunc() in getattr

Sent from my iPhone

On Jan 14, 2012, at 8:27 AM, Ryan McGrathreply@reply.github.com wrote:

Yet again, epic work. I'm flying to Switzerland momentarily, but can push out a point release of Twython to pypi when I touch down. Thanks again!


Reply to this email directly or view it on GitHub:
#56 (comment)

@ryanmcgrath
Copy link
Copy Markdown
Owner

Hey,

Yeah, I saw your tweet, but have only now sat down to deal with things. I've got some day-job things to take care of at the moment, but I'll make an exception and patch this up real quick - someone else fixed it already (Japanese).

Will roll this in and push a point release for sanity, full Requests stuff is next on the list. _

Thanks!

@michaelhelmick
Copy link
Copy Markdown
Collaborator Author

Ah, alright, cool. Not really sure what the diff between setFunc, and the custom _constructFunc is; but oh, well. At least someone already took care of it! Don't you love the OPS Community? Haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants