Extract subscription module into submodules#106
Merged
ryanoneill merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
Extract the 1000-line monolithic subscription module into 6 focused submodules while preserving all public API paths and test compatibility: - core.rs: Subscription trait, BoxedSubscription, Tick/Timer/Channel/Stream - combinators.rs: Mapped/Filter/Take/Debounce/Throttle subscriptions - ext.rs: SubscriptionExt trait and blanket impl - batch.rs: BatchSubscription and batch() function - interval.rs: IntervalImmediateSubscription and interval_immediate() - terminal.rs: TerminalEventSubscription and terminal_events() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 94 99 +5
Lines 9471 9471
=======================================
Hits 8791 8791
Misses 680 680 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/app/subscription/mod.rsinto 6 focused submodulescore.rs(258 lines): Subscription trait, BoxedSubscription, Tick/Timer/Channel/Stream subscriptionscombinators.rs(366 lines): Mapped, Filter, Take, Debounce, Throttle subscriptionsext.rs(128 lines): SubscriptionExt trait with combinator methodsbatch.rs(44 lines): BatchSubscription and batch() functioninterval.rs(107 lines): IntervalImmediateSubscription and interval_immediate()terminal.rs(112 lines): TerminalEventSubscription and terminal_events()mod.rsis 42 lines (re-exports only), down from 1000Test plan
cargo test --all-featurespasses (2882 unit + 267 doc)cargo clippy --all-features -- -D warningsclean🤖 Generated with Claude Code