Skip to content

Fix handleLoad call from setInterval #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Fix handleLoad call from setInterval #236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a455ea
fix handleLoad call
dannysindra Jan 13, 2023
962f0a9
nit
dannysindra Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Frame.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,10 @@ export class Frame extends Component {

// In certain situations on a cold cache DOMContentLoaded never gets called
// fallback to an interval to check if that's the case
loadCheck = setInterval(function loadCheckCallback() {
this.handleLoad();
}, 500);
loadCheck = () =>
setInterval(() => {
this.handleLoad();
}, 500);

renderFrameContents() {
if (!this._isMounted) {
Expand Down