(#212) Improve widget section presentation #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: [feature] GenerateUsageInsightsUseCase: implement rounding and add unit tests [test] ConsumptionGroupedCells: add unit tests [feature] InsightsCard: update to show the cost is reference cost (fake) or estimated cost (real) [feature] Insights: add isTrueCost attribute [refactor] UsageViewModel: split function into GenerateUsageInsightsUseCase [refactor] UserProfile: make all class properties non-null to simplify processing; add helper functions; allow demo mode to lookup rates [feature] Usage: minor UI string update [chore] Renovate: Update dependency io.github.koalaplot:koalaplot-core 0.6.0 to v0.6.1 [feature] UsageViewModel: bare minimum working code to calculate realistic half-hourly usage cost by 1:1 rate mapping; other presentation styles stays the old rough calculation [refactor] RateGroup: update getRateTrend to honour validTo == Instant.DISTANT_FUTURE [test] Unit test: replace validTo == null with Instant.DISTANT_FUTURE [refactor] Rate: change validTo to use Instant.DISTANT_FUTURE when API returns null [refactor] RestApiRepository: simplify getAccount() by returning Account? rather than List<Account> [test] AccountSamples: update agreements for use in demo mode [refactor] GetConsimptionAndcostUseCase: update error messages [refactor] ConsumptionDataGroup: rename to ConsumptionTimeFrame as suggested by ChatGPT [test] GetConsumptionAndCostUseCaseTest: update unit tests [feature] Consumptions: Add ConsumtionWithCost domain model; Update UseCase and Viewmodel to take this model; no real cost is calculated uet [refactor] Consumption: rename extension functions
* main: (99 commits) [test] OctopusRestApiRespository: add unit tests [feature] RestApiRepository: getStandingCharges() now exposes paymentMethod but default to Unknown [feature] OctopusRestApiRepository: add database caching to rates and standing charges [test] RateEntityKtTest: fix class name [feature] RateMapper: implement RateEntity mappers [feature] RateEntity: add coversRange() for repository use [refactor] Rate: remove vatExclusivePrice in domain model [chore] Renovate: Update dependency org.jetbrains.kotlinx.kover 0.8.1 to v0.8.2 [test] RoomDatabaseDataSource: add unit tests [test] RateDao: add unit tests and fix implementation [refactor] RoomDB: update Dao and DataSource to take paymentMethod as paymentMethod type [feature] RoomDB: change RateEntity.paymentMethod from String to PaymentMethod with converters [feature] RoomDB: finalise database for common rates storage [chore] Renovate: Update dependency androidx.test:core-ktx 1.6.0 to v1.6.1 [chore] Renovate: Update dependency androidx.test.ext:junit 1.2.0 to v1.2.1 [chore] Renovate: Update dependency androidx.test.espresso:espresso-core 3.6.0 to v3.6.1 [feature] StandingChargeDao: implement dao [feature] RoomDB: define StandardUnitRateEntity and StandingChargeEntity [test] Sample data: group all sample data under test.samples [chore] Renovate: Update dependency org.jetbrains.kotlinx:kotlinx-serialization-json 1.7.0 to v1.7.1 ...
…background with any colours
…e buttons in the future)
…ake list of Tariffs
… RageGaugeCountdownCard
…and rename to CurrentRateCard
…rce and apply animation to the trend indicator
…coded layout for expanded width
…g hardcoded layout for expanded width
ryanw-mobile
added
the
feature
rwmobi
approved these changes
Jun 29, 2024
Contributor
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All widgets on the Agile Screen and Usage Screen now share the same base Card Layout, which specifies a uniform max width.
When the window is extremely wide, we do not fully use the available width, and cap the widget width to WindowWidthSize.Compact. Since widgets are a part of the fixed layout, we simply hardcode the adaptive layout for now.
Some minor overall layout was updated.
Agile rate trend is now animated.