Skip to content

Conversation

@ryanw-mobile
Copy link
Owner

JetBrains' worst undiscussable KMP issue.
Updated Proguard to make desktop release work.

@ryanw-mobile ryanw-mobile added the chore Updating grunt tasks etc.; no production code change. label Jul 17, 2024
@ryanw-mobile ryanw-mobile requested a review from rwmobi July 17, 2024 19:27
@ryanw-mobile ryanw-mobile self-assigned this Jul 17, 2024
@ryanw-mobile ryanw-mobile linked an issue Jul 17, 2024 that may be closed by this pull request
@ryanw-mobile ryanw-mobile enabled auto-merge July 17, 2024 19:27
Copy link
Collaborator

@rwmobi rwmobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so 1984.

@codacy-production
Copy link
Contributor

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-2.21% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aa83079) 2505 1467 58.56%
Head commit (5abc019) 2612 (+107) 1472 (+5) 56.36% (-2.21%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#272) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codecov
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.34%. Comparing base (aa83079) to head (5abc019).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   54.34%   54.34%           
=======================================
  Files         106      106           
  Lines        2403     2403           
  Branches      415      415           
=======================================
  Hits         1306     1306           
  Misses        973      973           
  Partials      124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanw-mobile ryanw-mobile merged commit c74ccfb into main Jul 17, 2024
@ryanw-mobile ryanw-mobile deleted the fix/apollographql-proguard branch July 17, 2024 19:42
@ryanw-mobile ryanw-mobile added this to the GraphQL Migration milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Updating grunt tasks etc.; no production code change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix apolloGraphQL proguard

3 participants