ci(screenshots): open PR for baseline updates instead of direct push#352
Merged
ci(screenshots): open PR for baseline updates instead of direct push#352
Conversation
develop is a protected branch — direct pushes from github-actions[bot] are rejected. Switch the push/dispatch path to commit baselines to a temporary branch and open a PR targeting the triggering branch. The PR's screenshot comparison check passes automatically (same windows-2025 runner for both baseline and candidate), so it just needs a quick merge. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Build Performance Report⏱️ Build Time: 12 minutes 📊 Comparison with main branch:
✅ Within acceptable range This is an automated performance check |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Two issues flagged by the code scanning diff check on PR #352: artipacked: persist-credentials: true is required for the push step that creates the baseline-update branch. Added zizmor ignore comment to document the intentional choice. template-injection: ${{ github.ref_name }} was expanded directly in a PowerShell run block. Moved all context values (ref_name, run_id, server_url/repository) to named env: variables so the shell script reads them via $env:VAR — no inline template expansion in run steps. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Build Performance Report⏱️ Build Time: 12 minutes 📊 Comparison with main branch:
✅ Within acceptable range This is an automated performance check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developis a protected branch — direct pushes fromgithub-actions[bot]are rejected with GH006. Switches the push/dispatch path to:chore/update-screenshot-baselines-<run-id>branchwindows-2025runner), so it just needs a quick mergeThe PR regression gate (pull_request events) is unchanged.
After merging
Run the workflow manually on
developvia:It will open a baseline-update PR. Merge that PR and the screenshot checks on future PRs will pass cleanly.
🤖 Generated with Claude Code