fix: MonitorLauncher DI resolution fails — empty UI on startup#403
Merged
fix: MonitorLauncher DI resolution fails — empty UI on startup#403
Conversation
MS DI cannot resolve Func<> constructor parameters (healthCheckOverride, processRunningOverride, etc.) because they aren't registered in the container. DI does NOT use default parameter values — it requires all parameters to be resolvable. Fix: add a public DI constructor that takes only ILogger<MonitorLauncher>. The test constructor with Func overrides is now internal. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HOTFIX — beta.12 shows empty UI because MS DI cannot resolve the MonitorLauncher constructor.
The MonitorLauncher constructor had
Func<>parameters (healthCheckOverride, processRunningOverride, etc.) that the DI container tries to resolve but can't — they aren't registered. MS DI does NOT use default parameter values.Fix: add a public constructor taking only
ILogger<MonitorLauncher>for DI. The test constructor with Func overrides is nowinternal.Test plan
🤖 Generated with Claude Code