test: audit test suite — delete useless tests, add critical integration tests#406
Merged
test: audit test suite — delete useless tests, add critical integration tests#406
Conversation
…on tests Delete 3 trivial test files that only tested flag read/write or sort order: - ProviderSectionCollapseCatalogTests, ProviderSectionLayoutCatalogTests, ProviderMainWindowOrderingCatalogTests Add 15 real integration tests across 3 new files: MonitorDiResolutionTests (3 tests): - Full Monitor DI graph resolution matching Program.cs setup - All provider services resolve from complete container - UsageDatabase singleton forwarding works PaceCalculationEndToEndTests (7 tests): - Codex 71% used + weekly reset in 5d → projected 100%, "Over pace" - Codex 20% used + weekly reset in 5d → projected 70%, "On pace" - 5h burst 60% after 2h → projected 150% clamped, "Over pace" - 5h burst 10% after 2h → projected 25%, "On pace" - Projection consistency between color and final percent - Edge case: fully elapsed period ProviderResponseDeserializationTests (5 tests): - Codex full response with all quota windows + Spark - Codex minimal response with graceful degradation - Claude Code OAuth response with all detail types - Claude Code partial response handling - Error response handling for both providers Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test suite audit: deleted 3 trivial tests, added 15 real integration tests.
Deleted (tested nothing real)
Added
These tests would have caught the beta.12 DI regression and the pace calculation bugs.
Test plan
🤖 Generated with Claude Code