fix: DateTime overflow in pace calculation crashes UI rendering#407
Merged
fix: DateTime overflow in pace calculation crashes UI rendering#407
Conversation
CalculatePaceAdjustedColorPercent crashes with ArgumentOutOfRangeException when nextResetUtc is too close to DateTime.MinValue (stale provider data). The subtraction `nextResetUtc - periodDuration` underflows. Guard both CalculatePaceAdjustedColorPercent and CalculateProjectedFinalPercent against DateTime underflow. Falls back to raw usedPercent when the date math would overflow. Customer reported: 56 render failures per session, completely blank UI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HOTFIX — Customer reports completely blank UI. Logs show 56x per session:
Root cause:
nextResetUtc - periodDurationunderflows when stale provider data has a NextResetTime too close to DateTime.MinValue.Fix: guard against DateTime underflow in both
CalculatePaceAdjustedColorPercentandCalculateProjectedFinalPercent. Falls back to raw usedPercent.Test plan
🤖 Generated with Claude Code