fix: DateTime overflow in renderer crashes UI (beta.15)#417
Merged
Conversation
rygel
force-pushed
the
hotfix/renderer-datetime-overflow
branch
2 times, most recently
from
354e4b3 to
5f7b320
Compare
…main Moved to UsageMath (single source of truth): - GetPaceBadgeText: was in Renderer, ViewModel, CardDesigner (3 copies) - GetColorIndicatorPercent: was in Renderer and ViewModel (2 copies) - GetElapsedDays: was inline in ViewModel tooltip - FormatAbsoluteTime: was in ViewModel, CardDesigner (2 copies) - FormatAbsoluteDate: was in CardDesigner - FormatRelativeTime: was in ViewModel, SubViewModel, CardDesigner, Converter (4 copies) All callers now delegate to UsageMath. grep confirms zero duplicated period math, time formatting, or pace logic remains outside UsageMath. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rygel
force-pushed
the
hotfix/renderer-datetime-overflow
branch
from
5f7b320 to
0b4c5f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HOTFIX — beta.15 crashes with blank UI. Same DateTime overflow bug as beta.12/14 but in a different location:
ProviderCardRenderer.GetPaceBadgeText.The guard was added to
UsageMathbut not to the renderer's own pace badge method. Also fixes stale pace logic — renderer still used old expected-percent comparison instead of projection.Test plan
🤖 Generated with Claude Code