refactor: eliminate remaining duplicated logic across codebase#418
Merged
refactor: eliminate remaining duplicated logic across codebase#418
Conversation
- Delete FormatRelativeTimeUntil from MainWindow (use UsageMath.FormatRelativeTime) - Delete MaskString/MaskPath from InfoDialog (use PrivacyHelper) - Delete MaskAccountIdentifier/MaskString from MainWindowRuntimeLogic.Presentation (use PrivacyHelper) - Delete MaskAccountIdentifier/MaskString from SettingsWindow.Providers (use PrivacyHelper) - Add MaskAccountIdentifier to PrivacyHelper as single source of truth - Fix test that had inline pace badge logic (use UsageMath.GetPaceBadgeText) grep confirms zero duplicated pace/time/masking logic remains outside UsageMath and PrivacyHelper. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final pass — eliminate all remaining duplicated logic:
62 insertions, 168 deletions. grep confirms zero duplicated pace, time formatting, or masking logic remains outside UsageMath and PrivacyHelper.
Test plan
🤖 Generated with Claude Code