perf: startup optimization + consolidate remaining duplicated code#424
Merged
perf: startup optimization + consolidate remaining duplicated code#424
Conversation
…timeLogic Moved from ProviderCardRenderer + ProviderCardViewModel: - BuildTooltipContent (2 copies → 1) - ResolveResetTimes (2 copies → 1) - GetDetailDisplayName (2 copies → 1) - GetDetailDisplayValue (2 copies → 1) - GetDetailSortOrder (3 copies → 1, made internal in Presentation) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MainWindow and CollapsibleSectionViewModel now delegate to UIHelper. Converters keep their own fallbacks (converter-specific defaults). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Theme test correctly caught the update download progress window having no Background set (white on dark theme). Fixed with GetResourceBrush. Also updated test to recognize GetResourceBrush and UIHelper as valid theme-aware patterns. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Startup performance
Code deduplication
GetDetailDisplayName, GetDetailDisplayValue into MainWindowRuntimeLogic (10 copies → 5 methods)
124 insertions, 198 deletions from tooltip consolidation alone.
Test plan
🤖 Generated with Claude Code