fix: load preferences before Host.StartAsync to preserve UpdateChannel#537
Merged
fix: load preferences before Host.StartAsync to preserve UpdateChannel#537
Conversation
Preferences were loaded AFTER Host.StartAsync(), but the GitHubUpdateChecker DI singleton captured Preferences.UpdateChannel during Host.StartAsync(). Since Preferences was still the default (Stable) at that point, the singleton always started with Stable regardless of what was persisted on disk. Move preferences loading before Host.StartAsync() so the DI singleton captures the correct channel from disk (e.g. Beta). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
UpdateChannelpreference (Stable/Beta) was silently reset to Stable on every startup because preferences were loaded afterHost.StartAsync(), but theGitHubUpdateCheckerDI singleton capturedPreferences.UpdateChannelduring service construction insideHost.StartAsync(). At that point,Preferenceswas still the defaultnew AppPreferences()(Stable).Fix: Move
preferencesStore.LoadAsync()beforeHost.StartAsync()so the DI singleton captures the correct channel from disk.This is safe because
Host.Servicesis available after the constructor's.Build()call —StartAsync()only starts hosted services, not the DI container.Test plan
dotnet build— 0 errors🤖 Generated with Claude Code