fix: resolve SonarQube reliability and maintainability issues by rygel · Pull Request #555 · rygel/AIUsageTracker

rygel · 2026-04-16T05:03:40Z

Summary

Resolve all reliability-impacting issues (S6966, S7781) to achieve 0 open reliability bugs
Fix 43 SonarQube issues across blocker, critical, and medium severities covering dead code removal, unused parameters, nested ternaries, incorrect assertions, and exception handling
Remove hardcoded API token from sonar-issues.ps1 utility script, now reads from environment variable

Changes by category

Rule	Count	Description
S2699	5	Added explicit assertions to blocker tests
S2701	5	Replaced Assert.Equal(true/false) with Assert.True/False
S6966	2	Used await RunAsync/CloseAndFlushAsync
S1144	13	Removed unused private methods, fields, setters
S1172	10	Removed unused method parameters
S3358	11	Extracted nested ternaries to if/else
S112	9	Replaced System.Exception with specific types
S108	5	Documented intentional empty catch blocks
S4144	1	Removed duplicate method
S1854	1	Removed useless assignment
S2971	1	Simplified LINQ
S4487	1	Removed unread field
S1186	1	Removed empty method
S2365	1	Removed unused property
S1118	2	Added protected constructors
S3881	2	Fixed IDisposable pattern
S6580	2	Used CultureInfo for date parsing
S6562	2	Specified DateTimeKind
S3010	1	Moved static field init

Test plan

All 1360 tests pass (1166 + 148 + 46 across 3 test projects)
Build succeeds with 0 errors
SonarQube scan shows 0 open reliability issues, 0 vulnerabilities

github-actions · 2026-04-16T05:03:54Z

⚠️ Large PR Detected

This PR contains 1839 lines changed across 16 files.

Details:

📁 Files changed: 16
➕ Insertions: 1837
➖ Deletions: 2
📊 Total: 1839 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T05:53:02Z

⚠️ Large PR Detected

This PR contains 1847 lines changed across 17 files.

Details:

📁 Files changed: 17
➕ Insertions: 1845
➖ Deletions: 2
📊 Total: 1847 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T06:05:11Z

⚠️ Large PR Detected

This PR contains 1855 lines changed across 20 files.

Details:

📁 Files changed: 20
➕ Insertions: 1849
➖ Deletions: 6
📊 Total: 1855 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T06:08:34Z

⚠️ Large PR Detected

This PR contains 6192 lines changed across 59 files.

Details:

📁 Files changed: 59
➕ Insertions: 6186
➖ Deletions: 6
📊 Total: 6192 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T06:08:42Z

⚠️ Large PR Detected

This PR contains 1857 lines changed across 21 files.

Details:

📁 Files changed: 21
➕ Insertions: 1851
➖ Deletions: 6
📊 Total: 1857 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T06:12:41Z

⚠️ Large PR Detected

This PR contains 6194 lines changed across 59 files.

Details:

📁 Files changed: 59
➕ Insertions: 6187
➖ Deletions: 7
📊 Total: 6194 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T06:12:58Z

⚠️ Large PR Detected

This PR contains 1860 lines changed across 22 files.

Details:

📁 Files changed: 22
➕ Insertions: 1853
➖ Deletions: 7
📊 Total: 1860 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T07:50:42Z

⚠️ Large PR Detected

This PR contains 1892 lines changed across 22 files.

Details:

📁 Files changed: 22
➕ Insertions: 1874
➖ Deletions: 18
📊 Total: 1892 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T07:51:37Z

⚠️ Large PR Detected

This PR contains 1952 lines changed across 23 files.

Details:

📁 Files changed: 23
➕ Insertions: 1907
➖ Deletions: 45
📊 Total: 1952 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T08:04:19Z

⚠️ Large PR Detected

This PR contains 1957 lines changed across 23 files.

Details:

📁 Files changed: 23
➕ Insertions: 1911
➖ Deletions: 46
📊 Total: 1957 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T08:09:53Z

⚠️ Large PR Detected

This PR contains 1975 lines changed across 24 files.

Details:

📁 Files changed: 24
➕ Insertions: 1928
➖ Deletions: 47
📊 Total: 1975 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T08:38:30Z

⚠️ Large PR Detected

This PR contains 1983 lines changed across 24 files.

Details:

📁 Files changed: 24
➕ Insertions: 1936
➖ Deletions: 47
📊 Total: 1983 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T08:51:38Z

⚠️ Large PR Detected

This PR contains 1985 lines changed across 25 files.

Details:

📁 Files changed: 25
➕ Insertions: 1937
➖ Deletions: 48
📊 Total: 1985 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T09:11:21Z

⚠️ Large PR Detected

This PR contains 2002 lines changed across 25 files.

Details:

📁 Files changed: 25
➕ Insertions: 1954
➖ Deletions: 48
📊 Total: 2002 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

rygel · 2026-04-16T09:11:44Z

PR Grade: B+ (provisionally A- once CI is green)

Rationale:

Scope is focused and directly addresses the Sonar blockers and local scanner reliability.
Validation was run locally (pre-commit-check and end-to-end Sonar upload).
Remaining risk is CI status: multiple required checks are still pending at this moment.

Promotion criteria to A:

All required GitHub checks pass on commit 5ecce45a.

github-actions · 2026-04-16T09:39:13Z

⚠️ Large PR Detected

This PR contains 2007 lines changed across 25 files.

Details:

📁 Files changed: 25
➕ Insertions: 1959
➖ Deletions: 48
📊 Total: 2007 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

rygel · 2026-04-16T09:39:18Z

Coverage update applied:

scripts/sonar.ps1 now collects coverage with dotnet test --collect:"XPlat Code Coverage;Format=opencover".
Sonar begin now uses sonar.cs.opencover.reportsPaths=TestResults/**/coverage.opencover.xml.
Verified local run imports coverage successfully (Coverage Report Statistics: 199 main files with coverage).
New-code Sonar issues remain at 0.

…edentials)

… add .sonarqube to gitignore

…ognitive complexity

… variable)

…lection to scan script

… assertion

- Fix S2699: Add explicit assertions to 5 blocker tests - Fix S2701: Replace Assert.Equal(true/false) with Assert.True/False - Fix S6966: Use await RunAsync/CloseAndFlushAsync in Web Program.cs - Fix S7781: Use replaceAll over replace in fix_resources.js - Fix S1144: Remove unused private methods, fields, and setters - Fix S1172: Remove unused method parameters and their call sites - Fix S4144: Remove duplicate TryReadAuthDuplicate method - Fix S1854: Remove useless assignment in OpenRouterProvider - Fix S2971: Simplify LINQ .Where().FirstOrDefault() to .FirstOrDefault() - Fix S3358: Extract 11 nested ternary operations into if/else chains - Fix S112: Replace System.Exception throws with specific exception types - Fix S108: Add comments to intentional empty catch blocks - Fix S4487: Remove unread _debugMode field and SetDebugMode method - Fix S1186: Remove empty Configure method from Web Program.cs - Fix S2365/S3358: Remove unused MainWindowVisibilityItems property - Fix S1118: Add protected constructors to Program classes - Fix S3881: Fix IDisposable implementations to conform to dispose pattern - Fix S6580: Use CultureInfo.InvariantCulture for date parsing - Fix S6562: Specify DateTimeKind for DateTime creation - Fix S3010: Move static field assignment to static method - Add sonar-issues.ps1 utility script for querying SonarQube API

- ProviderDerivedModelAssignmentResolver: 15 tests (was 7.7%) - MonitorLauncherProcessController: 20 tests (was 15.2%) - GitHubAuthService: 15 tests (was 28.9%) - GitHubUpdateChecker: 10 tests (was 33.3%) - WebDatabaseService: 10 tests (was 46.8%) - AntigravityProvider: 20 tests (was 47.2%) - ConfigService: 11 tests (was 52.1%) - ProviderManager: 15 tests (was 61.9%) - Update sonar.ps1 to collect coverage from all test projects - Update sonar-issues.ps1 for coverage-by-file queries

github-actions · 2026-04-16T12:21:03Z

⚠️ Large PR Detected

This PR contains 2710 lines changed across 60 files.

Details:

📁 Files changed: 60
➕ Insertions: 2256
➖ Deletions: 454
📊 Total: 2710 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T12:39:40Z

⚠️ Large PR Detected

This PR contains 2717 lines changed across 60 files.

Details:

📁 Files changed: 60
➕ Insertions: 2263
➖ Deletions: 454
📊 Total: 2717 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions · 2026-04-16T12:46:47Z

⚠️ Large PR Detected

This PR contains 2708 lines changed across 60 files.

Details:

📁 Files changed: 60
➕ Insertions: 2254
➖ Deletions: 454
📊 Total: 2708 lines

Recommendation:
Consider splitting this PR into smaller, focused changes to make review easier and faster. PRs under 500 lines are ideal for thorough code review.

This is an automated message. Feel free to ignore if this PR is intentionally large.

github-actions Bot added the size: large label Apr 16, 2026

rygel force-pushed the feat/sonarqube-local branch from 493fe13 to a8eab0c Compare April 16, 2026 05:52

rygel force-pushed the feat/sonarqube-local branch from b612678 to 41f7a5e Compare April 16, 2026 06:08

github-actions Bot added the size: xlarge label Apr 16, 2026

rygel force-pushed the feat/sonarqube-local branch from 33aff31 to 3737ad3 Compare April 16, 2026 06:12

actions-user added 8 commits April 16, 2026 13:54

feat: add SonarQube local analysis setup

c583618

fix: resolve S2955, S3168, S1172 SonarQube warnings

43635cc

fix: suppress false positive S6418 in GeminiProvider (public OAuth cr…

7428809

…edentials)

fix: remove unused elapsedDays parameter from CreateBurnRateForecast;…

17f370d

… add .sonarqube to gitignore

refactor: extract header click handler to reduce cognitive complexity

14b6e06

refactor: extract identity key checker and object scanner to reduce c…

fa21918

…ognitive complexity

fix: resolve quality gate violations (MA0147 async void, S1481 unused…

18fa7bd

… variable)

fix: resolve quality gate - make CLI Program static, add coverage col…

0cfd14a

…lection to scan script

actions-user added 5 commits April 16, 2026 13:54

fix: resolve quality gate - make CLI Program static, add coverage col…

d44a193

…lection to scan script

fix: resolve ConfigureAwait guardrail violation and ConfigLoader test…

202a30c

… assertion

Fix Sonar blockers and harden local scanner script

08ac885

Add reliable Sonar coverage collection via OpenCover

98204f5

rygel force-pushed the feat/sonarqube-local branch from 1edfe85 to 024ade5 Compare April 16, 2026 10:55

rygel changed the title ~~feat: add SonarQube local analysis setup~~ fix: resolve SonarQube reliability and maintainability issues Apr 16, 2026

fix: add assertions to 3 tests flagged as S2699 blocker by SonarQube

9280c52

fix: exclude flaky integration tests from SonarQube coverage runs

ec07cc8

rygel merged commit ede4c9f into develop Apr 16, 2026
21 checks passed

rygel deleted the feat/sonarqube-local branch April 16, 2026 13:15

Conversation

rygel commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes by category

Test plan

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

rygel commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

rygel commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rygel commented Apr 16, 2026 •

edited

Loading