fix: resolve 71 SonarQube medium maintainability issues in new code#557
Merged
fix: resolve 71 SonarQube medium maintainability issues in new code#557
Conversation
- MA0006: Use string.Equals with StringComparison.Ordinal (4) - MA0002: Use StringComparer.Ordinal for dictionary lookups (3) - VSTHRD111/MA0004: Add ConfigureAwait(false) to all test awaits (25) - VSTHRD002: Replace .Result with await in GitHubAuthServiceTests (1) - VSTHRD105: Use TaskScheduler.Default in ContinueWith (1) - MA0011: Add CultureInfo.InvariantCulture to TryParse (1) - SA1122/SA1516/SA1513/IDE0055/SA1101/IDE0009: Auto-format via dotnet format - Update sonar-issues.ps1 to support new code period queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotnet formatfor style issues (SA1122, SA1516, IDE0055, SA1101, IDE0009)Changes
Test plan