fix: resolve ~250 SonarQube LOW severity issues#558
Merged
Conversation
- S2325: Make 46 methods static across Infrastructure, Monitor, UI.Slim, Web (55) - S3260: Mark 41 private classes as sealed in provider DTOs - S6667: Pass caught exception to logger in 27 catch blocks - S3267: Simplify 10 loops to LINQ (Select, Where, SelectMany) - S6608: Replace .First() with [0] indexing (4) - S1481: Remove unused local variables (2) - S1905: Remove unnecessary int casts (2) - S1450: Convert unused fields to local variables (2) - S1125: Remove unnecessary boolean literal (1) - S1940: Use opposite operator != instead of !(==) (1) - S3400: Replace constant-returning method with inline const (1) - S101: Rename ZAI class to Zai (1) - S6672: Fix logger to use enclosing type (1) - S6669: Rename logger field to match convention (2) - S7764: Prefer globalThis over window in JS (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix ~250 SonarQube LOW severity issues across 53 files in production code (no test file changes).
Changes by category
thisis not usedTest plan