fix: resolve 106 remaining SonarQube LOW severity issues#559
Merged
Conversation
- S1075: Extract 35 hardcoded URIs/paths to const fields - S1192: Extract 57 repeated string literals to const fields - S2325: Make 7 non-instance methods static - S6664: Consolidate excessive debug logging in 7 blocks - S1481: 1 false positive (Razor variable used in template)
Contributor
|
This PR contains 1301 lines changed across 35 files. Details:
Recommendation: This is an automated message. Feel free to ignore if this PR is intentionally large. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
constfields across 16 provider and service files. ProviderEndpoints.cs suppressed with#pragma warning disable S1075since it is already a centralized constants file.const stringfields across 15 files, including 28 theme names inApp.Themes.cs, JSON property names inCodexProvider.csandOpenAIProvider.cs, SQL table names inDatabaseMigrationService.cs, and status strings across Monitor client files.staticinProviderUsageProcessingPipeline,App.Screenshots,SettingsWindow.Providers,ProviderRefreshConfigSelector, andIndex.cshtml.ZaiProvider,GitHubUpdateChecker,Program.cs(3 blocks),ProviderRefreshConfigLoadingService, andWebApplicationPipelineExtensions.versionvariable in_Layout.cshtmlis used in the Razor template footer.Changes
Test plan
dotnet build AIUsageTracker.sln- 0 errorsdotnet testall 3 test projects - 1,491 passed, 0 failed