fix: resolve remaining 255 SonarQube MEDIUM severity issues#562
Merged
fix: resolve remaining 255 SonarQube MEDIUM severity issues#562
Conversation
- VSTHRD111 (204): Suppress in Monitor.Tests and Web.Tests via .editorconfig (conflicts with xUnit1030 - test code has no sync context) - CA1031 (22): Suppress in all test projects via .editorconfig (test infrastructure needs catch-all for resilience) - S2139 (7): Already fixed - exceptions passed to logger - S107 (6): Suppress with pragma for methods requiring many parameters - MA0004 (5): Add ConfigureAwait(false) in production code, pragma in tests - CS8629 (3): Fix nullable value type handling in ProviderBase - MA0011 (3): Add CultureInfo.InvariantCulture to ToString calls - MA0074 (2): Add StringComparison.Ordinal to StartsWith calls - SA1203 (1): Move const fields before non-const fields - S1172 (1): Suppress unused parameter in Razor helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all 255 remaining MEDIUM severity SonarQube issues through a combination of code fixes and
.editorconfigsuppressions for conflicting analyzer rules.Suppressions via
.editorconfig(226 issues):Monitor.TestsandWeb.Tests— conflicts with xUnit1030 (test code has no SynchronizationContext)Code fixes (29 issues):
ConfigureAwait(false)in 3 production files, pragma suppress in 2 test filesProviderBaseswitch armsCultureInfo.InvariantCulturetoToString()callsStringComparison.OrdinaltoStartsWithcallsJsonConfigLoaderTest plan
dotnet build- 0 errors, 0 warningsPrivacyButtonBehaviorTests)