#5 Obsidian Sync feature#6
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c3e93fdd6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Prepare Usecase for fetching data | ||
| summaryUC := usecase.NewSummaryUsecase(a.Store) | ||
| opts := usecase.SummaryOptions{ | ||
| IncludeHidden: false, // Default false for sync? Or true? Let's say false for now to keep private stuff private unless wanted. | ||
| // Logic for date selection relies on same logic as summary | ||
| } |
There was a problem hiding this comment.
The sync path builds SummaryOptions without providing HiddenDirs, so GetSummary never applies the hidden-directory filter (it only runs when HiddenDirs is non-empty). As a result, wip sync will export events from directories the user explicitly configured as hidden, which defeats the privacy intent called out in the comment and can leak logs into Obsidian. This shows up whenever a user has hidden_directories configured and runs wip sync expecting hidden paths to be excluded; pass HiddenDirs: a.HiddenDirs() (and optionally respect --include-hidden) to ensure the filter is applied.
Useful? React with 👍 / 👎.
1 participant
No description provided.