Skip to content

refactor: remove unused ModelSpecSchema#35

Merged
ryoppippi merged 1 commit intomainfrom
remove-unused
Jun 8, 2025
Merged

refactor: remove unused ModelSpecSchema#35
ryoppippi merged 1 commit intomainfrom
remove-unused

Conversation

@ryoppippi
Copy link
Owner

No description provided.

@ryoppippi ryoppippi merged commit be8d7d3 into main Jun 8, 2025
6 checks passed
@ryoppippi ryoppippi deleted the remove-unused branch June 8, 2025 12:40
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ryoppippi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request. This PR focuses on code cleanup by removing unused type definitions and schemas. Specifically, it removes the ModelSpecSchema, the ModelSpec type, the LiteLLMModelPricesSchema, and the LiteLLMModelPrices type from the src/types.ts file. The title indicates this is a refactoring step to eliminate dead code.

Highlights

  • Code Cleanup: The primary goal of this PR is to remove code that is no longer being used in the project.
  • Schema and Type Removal: The ModelSpecSchema and related types (ModelSpec, LiteLLMModelPricesSchema, LiteLLMModelPrices) have been identified as unused and are removed in this change.

Changelog

  • src/types.ts
    • Removed the unused ModelSpecSchema definition.
    • Removed the unused ModelSpec type alias.
    • Removed the unused LiteLLMModelPricesSchema definition.
    • Removed the unused LiteLLMModelPrices type alias.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 8, 2025

Open in StackBlitz

npm i https://pkg.pr.new/ryoppippi/ccusage@35

commit: 9f44d5f

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the unused ModelSpecSchema, ModelSpec, LiteLLMModelPricesSchema, and LiteLLMModelPrices from src/types.ts. This is a good cleanup effort that improves code maintainability by reducing unused code and simplifying the types definition file.

I've cross-referenced the codebase provided and can confirm that these types do not appear to be used elsewhere, and their removal should not impact existing functionality. The pricing-fetcher.ts module uses a more specific ModelPricingSchema for its needs.

Well done on identifying and removing this dead code!

Summary of Findings

  • Code Cleanliness and Maintainability: The removal of ModelSpecSchema and its associated types (ModelSpec, LiteLLMModelPricesSchema, LiteLLMModelPrices) is a positive change. This action reduces the codebase size, eliminates dead code, and improves overall maintainability by making the types.ts file more concise and focused on actively used definitions.

Merge Readiness

The changes in this pull request are straightforward and beneficial. The removal of unused code has been verified, and it enhances the clarity of the types.ts file. I believe this PR is in good shape and ready for merging. As always, ensure any CI checks pass and consider if any other team members should review based on your internal processes. I am not authorized to approve pull requests.

ryoppippi added a commit that referenced this pull request Jun 22, 2025
refactor: remove unused ModelSpecSchema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant