Skip to content

chore: remove exports of types#36

Merged
ryoppippi merged 1 commit intomainfrom
fix-exports
Jun 8, 2025
Merged

chore: remove exports of types#36
ryoppippi merged 1 commit intomainfrom
fix-exports

Conversation

@ryoppippi
Copy link
Owner

No description provided.

@ryoppippi ryoppippi requested a review from Copilot June 8, 2025 13:19
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ryoppippi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, gemini-code-assist here to provide a summary of this pull request by @ryoppippi. The primary goal of this PR is to remove the explicit export of type definitions from the package and exclude the types.ts file from the build process. This suggests that the types defined in src/types.ts are likely intended for internal use only or are being handled via generated declaration files (.d.ts) from other source files, and thus should not be part of the public package exports or the main build output.

Highlights

  • Remove Type Export: The PR removes the ./types entry from the exports field in package.json, preventing consumers from directly importing types via this path.
  • Exclude Type File from Build: The tsdown.config.ts file is updated to explicitly exclude src/types.ts from the list of entry points for the build process, ensuring this file is not compiled into the distribution bundle.

Changelog

  • package.json
    • Removed the ./types export from the exports field.
  • tsdown.config.ts
    • Added !./src/types.ts to the entry array to exclude the types file from the build.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the exports of the types module to streamline the build outputs.

  • Excludes "types.ts" from the tsdown entry in tsdown.config.ts
  • Removes the "./types" export from package.json

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tsdown.config.ts Excludes "./src/types.ts" from the build process.
package.json Removes the "./types" export so that types aren't distributed.
Comments suppressed due to low confidence (2)

tsdown.config.ts:6

  • Consider adding a comment explaining why './src/types.ts' is excluded to help future maintainers understand that this removal is intentional.
'!./src/types.ts',

package.json:25

  • Ensure that any consumers of the package are informed of the removal of the './types' export, potentially by updating the changelog or release notes.
"./types": "./dist/types.js",

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the export of the ./types module from the package.json and excludes src/types.ts from the build process. This is a good change that clarifies the public API of the package, ensuring that types intended for internal use are not exposed to consumers.

Summary of Findings

  • Removed internal type export: The pull request correctly removes the export mapping for ./types in package.json and excludes src/types.ts from the build configuration. This aligns with the likely intent to keep the types defined in src/types.ts internal to the package. No issues were found at the requested severity levels (medium, high, critical) in the changes.

Merge Readiness

The changes in this pull request are straightforward and correctly implement the stated goal of removing the export of internal types. Based on my review, the code is in good shape to be merged. As per my instructions, I am unable to approve the pull request directly; please have another reviewer approve this code before merging.

@ryoppippi ryoppippi merged commit 7d9a6e5 into main Jun 8, 2025
8 of 9 checks passed
@ryoppippi ryoppippi deleted the fix-exports branch June 8, 2025 13:20
ryoppippi added a commit that referenced this pull request Jun 22, 2025
chore: remove exports of types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants