Skip to content

chore: stop exporting shared args#39

Merged
ryoppippi merged 1 commit intomainfrom
remove-shard-args
Jun 8, 2025
Merged

chore: stop exporting shared args#39
ryoppippi merged 1 commit intomainfrom
remove-shard-args

Conversation

@ryoppippi
Copy link
Owner

This pull request removes references to the shared-args module from the project configuration files. The changes ensure that the module is no longer included in the build process or exported.

Configuration updates:

  • package.json: Removed the export entry for ./shared-args, which previously pointed to ./dist/shared-args.js.
  • tsdown.config.ts: Excluded shared-args.ts from the entry configuration, preventing it from being included in the build output.

@ryoppippi ryoppippi merged commit 380b1e4 into main Jun 8, 2025
9 checks passed
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ryoppippi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a quick summary of this pull request. This PR, authored by ryoppippi, focuses on cleaning up the project configuration by removing references to the shared-args module. The primary goal is to ensure this module is no longer included in the build process or exposed as an export from the package.

Highlights

  • Configuration Cleanup: The pull request updates project configuration files to remove explicit references to the shared-args module.
  • Remove Package Export: The shared-args module is no longer listed in the exports field of the package.json, preventing it from being imported directly from the package.
  • Exclude from Build: The shared-args.ts file is now explicitly excluded from the list of entry points used by the build configuration (tsdown.config.ts), ensuring it is not processed during the build.

Changelog

  • package.json
    • Removed the ./shared-args entry from the exports field (line 25).
  • tsdown.config.ts
    • Added !./src/shared-args.ts to the entry array to exclude the file from the build process (line 7).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ryoppippi ryoppippi deleted the remove-shard-args branch June 8, 2025 13:30
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 8, 2025

Open in StackBlitz

npm i https://pkg.pr.new/ryoppippi/ccusage@39

commit: 4dbcd6e

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the shared-args module from the package's exports and standalone build outputs. The changes in package.json and tsdown.config.ts are clear, concise, and directly achieve the goal stated in the PR description: to stop exporting and separately building shared-args.

This is a good cleanup task that simplifies the project's build and distribution structure. The changes are well-targeted and appear correct. Well done!

Summary of Findings

  • Code Quality and Correctness: The changes are well-structured, clear, and directly implement the PR's objective. No issues of medium, high, or critical severity were identified in the diff. The modifications appear to correctly achieve the goal of ceasing the export and separate build of the shared-args module.
  • Configuration Accuracy: The modifications to package.json (removing the export entry) and tsdown.config.ts (adding an exclusion for shared-args.ts from build entries) are accurate and consistent with the intent described.
  • Adherence to Review Severity Settings: No review comments were added as no issues meeting the specified severity threshold (medium, high, or critical) were found. No low-severity issues warranting specific mention in this summary were identified either.

Merge Readiness

From my review, these changes are straightforward, safe, and correctly implement the intended cleanup. The code quality of the changes is good. I believe this PR is ready for merging, pending any other necessary reviews or CI checks.

Please note that as an AI assistant, I am not authorized to approve pull requests. Ensure appropriate human review and approval are obtained before merging.

ryoppippi added a commit that referenced this pull request Jun 22, 2025
chore: stop exporting shared args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant