Skip to content

Conversation

@ryoppippi
Copy link
Owner

@ryoppippi ryoppippi commented Nov 14, 2025

Reverts #701
it break layout in compact mode

we consider it twice

Summary by CodeRabbit

  • Bug Fixes
    • Improved responsive table layout by optimizing minimum column widths, enabling more flexible resizing behavior for numeric data columns.

@coderabbitai
Copy link

coderabbitai bot commented Nov 14, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The change reduces the minimum width constraint for right-aligned columns in the ResponsiveTable.toString method from 14 to 10, affecting responsive table rendering behavior for numeric columns.

Changes

Cohort / File(s) Summary
Right-aligned column width adjustment
packages/terminal/src/table.ts
Decreased minimum width for right-aligned (numeric) columns from 14 to 10 in responsive table resizing logic

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A narrower path for numbers to tread,
From fourteen down to ten instead,
Tables shrink with grace and care,
More space for content everywhere!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-701-fix/table-truncation-700

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 642b666 and 8b94943.

📒 Files selected for processing (1)
  • packages/terminal/src/table.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ryoppippi ryoppippi merged commit c5fa8e7 into main Nov 14, 2025
12 of 15 checks passed
@ryoppippi ryoppippi deleted the revert-701-fix/table-truncation-700 branch November 14, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants