Conversation
…d remove `-p`/`--path` option""
|
Warning Rate limit exceeded@ryoppippi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 36 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ryoppippi
deleted the
revert-76-revert-70-copilot/fix-4a5d6a32-927f-4cf5-be0f-269b8b06a70d
branch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ryoppippi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request re-implements the strategy for specifying the Claude data directory, shifting from a command-line option (--path) to an environment variable (CLAUDE_CONFIG_DIR). This change centralizes the configuration of the data directory, ensuring all commands consistently locate Claude data based on the environment variable, and includes robust validation and updated documentation.
Highlights
- Configuration Method Change: The
--pathcommand-line option for specifying the Claude data directory has been removed. The tool now exclusively uses theCLAUDE_CONFIG_DIRenvironment variable for this purpose. - Core Logic Adaptation: All commands (
daily,monthly,session,mcp) have been updated to retrieve the Claude data directory path via a newgetDefaultClaudePath()utility function, which prioritizes theCLAUDE_CONFIG_DIRenvironment variable. - Documentation Update: The
README.mdhas been thoroughly updated to reflect the new configuration method, including revised command examples and a dedicated section explaining the use of theCLAUDE_CONFIG_DIRenvironment variable. - Path Validation and Testing: The
getDefaultClaudePath()function now includes robust validation to ensure the specified Claude data directory exists and is a valid directory. Comprehensive unit tests have been added to cover various scenarios for this function, including environment variable presence, default path fallback, and error handling for invalid paths. - New Dependency: A new dependency,
path-type, has been introduced to facilitate reliable checks for directory existence.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
commit: |
There was a problem hiding this comment.
Code Review
This pull request reverts the previous feature that allowed specifying the Claude directory with the -p or --path option, and instead relies solely on the CLAUDE_CONFIG_DIR environment variable. The changes primarily involve removing the --path argument and updating the code to use getDefaultClaudePath() to determine the Claude data directory. The README has also been updated to reflect these changes.
| if (!isDirectorySync(envClaudeCodePath)) { | ||
| throw new Error( | ||
| ` Claude data directory does not exist: ${envClaudeCodePath}. | ||
| Please set CLAUDE_CONFIG_DIR to a valid path, or ensure ${DEFAULT_CLAUDE_CODE_PATH} exists. | ||
| `.trim(), | ||
| ); |
There was a problem hiding this comment.
The error message could be improved by suggesting the user create the default directory if they intend to use it. Also, consider adding a newline after the directory name in the error message for better readability.
throw new Error(
`Claude data directory does not exist: ${envClaudeCodePath}.\n` +
`Please set CLAUDE_CONFIG_DIR to a valid path, or ensure ${DEFAULT_CLAUDE_CODE_PATH} exists (you may need to create it).`
);1 participant
Reverts #76