Conversation
Also, simplify the CI pipeline to use pre-commit instead of individual checks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
miio/extract_tokens.py
Outdated
| cipher = Cipher( | ||
| algorithms.AES(key), modes.ECB(), backend=default_backend() # nosec | ||
| algorithms.AES(key), | ||
| modes.ECB(), |
Check failure
Code scanning / SonarCloud
Encryption algorithms should be used with secure mode and padding scheme
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1980 +/- ##
=======================================
Coverage 82.23% 82.23%
=======================================
Files 197 197
Lines 19127 19127
Branches 1050 1050
=======================================
Hits 15729 15729
Misses 3220 3220
Partials 178 178 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, simplify the CI pipeline to use pre-commit instead of individual checks