Corrected link in discovery.rst and Xiaomi Air Purifier Pro fix#465
Merged
syssi merged 3 commits intorytilahti:masterfrom Jan 21, 2019
Merged
Corrected link in discovery.rst and Xiaomi Air Purifier Pro fix#465syssi merged 3 commits intorytilahti:masterfrom
syssi merged 3 commits intorytilahti:masterfrom
Conversation
syssi
approved these changes
Jan 21, 2019
Collaborator
|
@swiergot Could you update the unit tests, too! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope you don't mind I also include a small fix for Air Purifier Pro. I cannot see any distinction between different Air Purifier models. Either this code doesn't care that some models might not accept higher values or so far all models have had a max of 16. Please advise.