Skip to content

Add pwzn relay#537

Merged
rytilahti merged 6 commits intorytilahti:masterfrom
SchumyHao:master
Sep 11, 2019
Merged

Add pwzn relay#537
rytilahti merged 6 commits intorytilahti:masterfrom
SchumyHao:master

Conversation

@SchumyHao
Copy link
Contributor

Signed-off-by: SchumyHao schumyhaojl@126.com

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 70.753% when pulling 9b8173a on SchumyHao:master into dd01456 on rytilahti:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 70.753% when pulling 9b8173a on SchumyHao:master into dd01456 on rytilahti:master.

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the PR! Do you have more information about device besides the model? I left some comments behind which will make the code much cleaner.

@SchumyHao
Copy link
Contributor Author

Hi @rytilahti

There are two device models pwzn.relay.apple pwzn.relay.banana
Device is like this
image

@SchumyHao
Copy link
Contributor Author

I update code as @rytilahti requied

@rytilahti
Copy link
Owner

Looks good, thanks! Can you update README's supported devices section? Also, are these relays discoverable? If so, please adjust the discovery.py accordingly, and this can then be merged!

@SchumyHao
Copy link
Contributor Author

Hi @rytilahti

Sorry for late response. I'm busy with my work those days.

This device can not discovered token is not accessable.
So I only update README.

Signed-off-by: SchumyHao <schumyhaojl@126.com>
Signed-off-by: SchumyHao <schumyhaojl@126.com>
Signed-off-by: SchumyHao <schumyhaojl@126.com>
Signed-off-by: SchumyHao <schumyhaojl@126.com>
Signed-off-by: SchumyHao <schumyhaojl@126.com>
Signed-off-by: SchumyHao <schumyhaojl@126.com>
@SchumyHao
Copy link
Contributor Author

Any update about this PR?
I checked the CI error logs, it seems not caused by my patches

@rytilahti
Copy link
Owner

Indeed, the errors are odd, do you have an idea @syssi? This can be merged now though, thanks @SchumyHao! 🎉

@rytilahti rytilahti merged commit 7df6821 into rytilahti:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants