Improve toiletlid various parameters#579
Merged
rytilahti merged 4 commits intorytilahti:masterfrom Nov 28, 2019
scp10011:master
Merged
Improve toiletlid various parameters#579rytilahti merged 4 commits intorytilahti:masterfrom scp10011:master
rytilahti merged 4 commits intorytilahti:masterfrom
scp10011:master
Conversation
1.add work_state analysis 2.add xiaomi_band interface
rytilahti
reviewed
Nov 27, 2019
Owner
rytilahti
left a comment
rytilahti
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks generally good to me, I left behind a couple of potential improvements, please let me know what do you think.
un/bind_xiaomi_band return bind or unbind result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.add work_state analysis
2.add xiaomi_band interface