Bug fixes and recursive searching for all matches#2
Merged
s-heppner merged 23 commits intos-heppner:masterfrom Jun 28, 2024
Merged
Bug fixes and recursive searching for all matches#2s-heppner merged 23 commits intos-heppner:masterfrom
s-heppner merged 23 commits intos-heppner:masterfrom
Conversation
Add path key to meta information.
This reverts commit bae3645.
s-heppner
requested changes
Jun 20, 2024
Owner
s-heppner
left a comment
s-heppner
left a comment
There was a problem hiding this comment.
I think the biggest issue I see at the moment is the cross-dependency you introduced to the semantic_id_resolver.
If possible at all, I would avoid calling that in as a dependency.
If that doesn't work out, my suggestion is to create a completely new repository for the test framework, where you pull in both projects as dependency.
s-heppner
reviewed
Jun 26, 2024
Remove not used debug function read_root()
s-heppner
requested changes
Jun 27, 2024
Owner
s-heppner
left a comment
s-heppner
left a comment
There was a problem hiding this comment.
Except for this minor thing, it looks good to me.
s-heppner
changed the title
Owner
|
I took the liberty to improve your PR title and message, so that we can use it as commit message, when we squash and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements:
recursively
get_all_matchesof the server127.0.0.1to0.0.0.0to work inside ofdocker networks
actually return all relevant matches